docs: Add BN metric alert configuration suggestions #1851
Merged
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nana-EC
added
Block Node
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
force-pushed
the
1615-metric-alert-recommendations
branch
from
7409400 to
25f6041
Compare
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
requested review from
AlfredoG87,
ata-nas,
jasperpotts,
jsync-swirlds,
mustafauzunn and
rockysingh
Contributor
mustafauzunn
left a comment
mustafauzunn
left a comment
There was a problem hiding this comment.
conventional-pr-title check is not passing.
Beside that looking good
jsync-swirlds
approved these changes
Nov 20, 2025
Contributor
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Just some optional suggestions for alert conditions.
AlfredoG87
approved these changes
Nov 24, 2025
Contributor
AlfredoG87
left a comment
AlfredoG87
left a comment
There was a problem hiding this comment.
LGTM. just a couple of nit suggestions.
Nana-EC
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1851 +/- ##
============================================
+ Coverage 80.57% 80.58% +0.01%
+ Complexity 1178 1177 -1
============================================
Files 127 127
Lines 5550 5553 +3
Branches 591 591
============================================
+ Hits 4472 4475 +3
- Misses 805 806 +1
+ Partials 273 272 -1 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Provide metric alerting value suggestions to allow operators to get going quickly on observing their BN
Related Issue(s)
Fixes #1615